Start powering the spreadsheet from organizer columns #10680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhollis
commented
Aug 9, 2024
bhollis
commented
Aug 9, 2024
Comment on lines
+330
to
+346
| isSpreadsheet && | ||
| c({ | ||
| id: 'hash', | ||
| header: 'Hash', | ||
| csv: 'Hash', | ||
| value: (i) => i.hash, | ||
| }), | ||
| isSpreadsheet && | ||
| c({ | ||
| id: 'id', | ||
| header: 'Id', | ||
| csv: 'Id', | ||
| value: (i) => `"${i.id}"`, | ||
| }), |
There was a problem hiding this comment.
I had to add a few spreadsheet-only columns.
bhollis
commented
Aug 9, 2024
src/app/organizer/Columns.tsx
Outdated
| @@ -588,9 +706,11 @@ export function getColumns( | |||
| header: t('Organizer.Columns.Level'), | |||
| value: (item) => item.craftedInfo?.level, | |||
| defaultSort: SortDirection.DESC, | |||
| csvVal: (value) => ['Crafted Level', value ?? 0], | |||
There was a problem hiding this comment.
In general I want columns to return undefined for their value if the column doesn't apply. But then annoyingly the CSV was inconsistent about whether a column was undefined or zeroed.
bhollis
commented
Aug 9, 2024
| * This builds stat infos for all the stats that are relevant to a particular category of items. | ||
| * It will return the same result for the same category, since all items in a category share stats. | ||
| */ | ||
| export function buildStatInfo(items: DimItem[]): { |
There was a problem hiding this comment.
Moved from ItemTable.tsx
bhollis
force-pushed
the
organizer-spreadsheets
branch
from
a29bf12 to
44f5080
Compare
robojumper
reviewed
Aug 10, 2024
Co-authored-by: robojumper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is maybe overkill, but it's something I've wanted to do for a long time. With this change, the inventory spreadsheets are entirely driven by the column definitions from the Organizer. This wasn't quite as smooth as I had imagined, because I wanted to preserve the output of the spreadsheets as they were, which required a bit more custom stuff than I had wanted. For example, every column needs a custom non-localized name, and the order of columns needs to be handled in a separate list. However, my goal was to make it so you can't accidentally add a column to Organizer without it appearing in Spreadsheets and vice versa, and that goal was achieved.
Some actual changes: