-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace red background of cannotRoll perks with dotted circle outline #10679
Conversation
Nice. The one bit that I'm not entirely happy with is that this doesn't really communicate "can't roll" to me - it seems more like "not unlocked" or something like that. I'm not sure what the solution is. The perk is there, it's just no longer unlockable for new rolls... |
Thoughts on this? It's a little bit awkward but directly ties the concept of the dashed icon to the tooltip warning about cannotRoll. |
I'm not sure that's quite it either. Maybe the dashed border is fine on its own. |
Yeah that's quite nice. |
Fixes #10550
This is more readable than the slightly different shades of red used for selected/unselected cannotRoll perks.
Alternatives considered: small faExclamationCircle in the bottom right/left of the icon. This ended up clashing with the thumbs up icon if on the bottom right, and the enhancement arrow if on the bottom left.
Screenshots:
Updated screenshots for later changes in this PR:
Realigned dashes so gaps are in cardinal directions:
Added dashed circle to tooltip text: