Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to show each class's armor on separate lines in vault #10678

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

FlaminSarge
Copy link
Contributor

@FlaminSarge FlaminSarge commented Aug 8, 2024

Closes #10355

Screenshot 2024-08-08 at 1 50 45 AM Screenshot 2024-08-08 at 1 53 08 AM Screenshot 2024-08-08 at 1 49 51 AM

@FlaminSarge
Copy link
Contributor Author

I think the text on the setting doesn't read well, would like suggestions on it.

@bhollis
Copy link
Contributor

bhollis commented Aug 8, 2024

You don't need to block on API changes - you can add new settings directly to initial-settings.ts and we move them over occasionally.

@FlaminSarge FlaminSarge marked this pull request as ready for review August 8, 2024 21:27
@FlaminSarge
Copy link
Contributor Author

You don't need to block on API changes - you can add new settings directly to initial-settings.ts and we move them over occasionally.

Oh cool, that's a nice setup.

config/i18n.json Outdated Show resolved Hide resolved
Co-authored-by: Ben Hollis <[email protected]>
@bhollis bhollis merged commit 5f726d9 into DestinyItemManager:master Aug 9, 2024
6 checks passed
@FlaminSarge FlaminSarge deleted the armor-grouping branch August 9, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow the armor groupings to also be separated onto different lines like the weapon groupings
2 participants