-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Europa theme godroll indicator color and add godroll/archived to item preview on settings page #10673
Conversation
…d/bad rolls when previewing themes
I may need some input from non-colorblind folks on the visibility of the thumbs-down on some themes. |
if you're going to display archived as an example it should probably be greyed out by default as archived items are. Otherwise I see no reason to have all the tags as examples archived could make sense... If it was representative but it's not in this example. thumbs a good ideas for the preview, new item dot never changes so no real need for that either, we could fix the crafted icons in this while we are at it too, it's pretty invisible on some themes. |
I should also add mobile screenshots.
Oh you're totally right, I forgot about that. Also doubles as not-matching current search query too, I think.
I figured since we're including 4 items for thumbs up/thumbs down + masterwork/not, might as well have different tags on them. Wondering if I should also include
We can merge #10670 and add both enhanced+crafted to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure of the overall value of showing previews of all of these different weapons tiles - thumbs-down especially is not in any wishlist a user is likely to come across.
The idea behind the preview icons was solely to show the effect of specific settings - the "show new items" setting, and the "icon size" setting. We don't actually need more examples beyond that IMO.
I agree that thumbs-down is a case that will rarely come up, but I do feel that Theme should be added to the list of the settings that it's meant to preview (changing theme then tabbing back over to Inventory to see how it looks would be really bad UX). I'll remove the thumbs-down cases, but how do we feel about the others for the sake of Theme previewing? |
Fixes #10640
Only including two mobile screenshots, for Default and Europa themes, as it's a bit redundant to have all of them.
Screenshots: