Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes uppercase in side menus #10641

Closed
wants to merge 1 commit into from
Closed

removes uppercase in side menus #10641

wants to merge 1 commit into from

Conversation

lowPolySkeleton
Copy link
Member

this removes the uppercase transform from the side menus. there was a suggestion on discord for this and TBH all caps is harder to parse and there are a lot in those side menus. This applies to all pages with side menus, including loadouts, and yes i added empty-space on the vendor sections.

BEFORE:
image

After:
image

@bhollis
Copy link
Contributor

bhollis commented Jul 17, 2024

Maybe it's familiarity but the mixed case isn't much easier for me to read, and it doesn't feel as "Destiny". I like it on the Vendors and Loadouts screen, but not on Records, Progress, and Settings. On the Loadouts screen it's a bit weird that they're all caps in the main section but mixed-case on the sidebar.

@braddadocio
Copy link

Everything I read on this kind of thing says if you use it, it should be used sparingly. Headings is one thing, but to use it for headings as well as the stuff under the headings is too much.

@bhollis
Copy link
Contributor

bhollis commented Jul 17, 2024

Agreed. In this case however each loadout is in fact a top level heading. The lowercase works well when there's two layers of hierarchy, such as on Vendors.

@braddadocio
Copy link

Oh, sure. I don't think the presentation for the main section and the sidebar have to match. Although, I don't think they're top-level... they are all underneath an episode/season heading in the main section (which isn't in all caps), and those are under a "DIM LOADOUTS" heading.

@lowPolySkeleton
Copy link
Member Author

yeah I mean it's a change... it's certainly less destiny.., but DIM was always meant to be Destiny but better where it could be. I also don't think the headings of the body sections need to match the case of the navigation. Nice part about loudouts at least is that people can make them all caps if they want...

@bhollis
Copy link
Contributor

bhollis commented Aug 5, 2024

Yeah I get it. I think I just personally don't like the way it looks, since all our collapsible headers and main-body headers and all that are uppercase.

@lowPolySkeleton
Copy link
Member Author

yeah that's fair, changing the headers would be a much larger change that would fairly drastically affect the look and feel of DIM (I don't think it would be a bad change) but more than I'm willing to fight for and hear from the discord about :P so i'll close this if we want to revisit we can later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants