Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay prismatic icon with selected super #10517

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Conversation

ryan-rushton
Copy link
Contributor

Overview

A hacky PR to overlay the super icon over the top of the prismatic icon.

@bhollis
Copy link
Contributor

bhollis commented Jun 11, 2024

This is kinda what I was thinking, with the class icon erased from the background like we do for the other subclasses:

Screenshot 2024-06-10 at 6 49 59 PM

To me this reads as "prismatic with stasis super" but I recognize that not everybody might see that.

@bhollis
Copy link
Contributor

bhollis commented Jun 16, 2024

Tweaked it a bit more - I don't think it looks bad?

Screenshot 2024-06-16 at 12 37 13 AM Screenshot 2024-06-16 at 12 37 05 AM

@bhollis bhollis marked this pull request as ready for review June 28, 2024 05:16
@bhollis bhollis merged commit 7a5517a into master Jun 28, 2024
7 checks passed
@bhollis bhollis deleted the super-over-prismatic branch June 28, 2024 05:16
@bhollis
Copy link
Contributor

bhollis commented Jun 28, 2024

Merging as-is so we have something in place. I think it looks good, but we can certainly keep tweaking from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants