Update to ESLint v9 / flat config, add regex and new react lints #10364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One blocker is that eslint-plugin-react is not compatible with eslint 9, even with the compatibility shims, because they removed some support that was long-deprecated. |
|
Currently just waiting on hluisson/eslint-plugin-jsx-expressions#18 |
|
We'll also need to finally give up on fork-ts-checker |
bhollis
commented
Aug 5, 2024
bhollis
changed the title
robojumper
approved these changes
Aug 5, 2024
Comment on lines
+60
to
61
| // eslint-disable-next-line @eslint-react/hooks-extra/prefer-use-state-lazy-initialization | ||
| const [selectedFilters, setSelectedFilters] = useState<Option<FilterPillType>[]>(emptyArray()); |
There was a problem hiding this comment.
Could this just be useState<...>(emptyArray)? Not that it matters much
There was a problem hiding this comment.
It could - I struggled with it a bit because emptyarray should be inlined and that's cheaper than conditionally executing a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to wait for more of the ecosystem to support eslint v9, but in the meantime here's some of the work to move over to the new config system.