Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inherited colors for svg text #283

Open
jahirfiquitiva opened this issue Feb 2, 2024 · 2 comments
Open

Use inherited colors for svg text #283

jahirfiquitiva opened this issue Feb 2, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jahirfiquitiva
Copy link

Is your feature request related to a problem? Please describe.

Since we can have/use light and dark themes, the generated SVG colors might not always have a color with enough contrast.

Describe the solution you'd like

Make the SVG use the inherited color by default (i.e. if no specific color is set in the URL).
This can be done with css and the inherit or currentColor properties.

@jahirfiquitiva jahirfiquitiva added the enhancement New feature or request label Feb 2, 2024
@DenverCoder1
Copy link
Owner

That doesn't work when the svg is used through an img tag, styling features do not get applied.

You can use special markup to make different versions for dark mode and light mode, though - https://github.com/DenverCoder1/readme-typing-svg/blob/main/docs/faq.md#how-do-i-make-different-svgs-for-dark-mode-and-light-mode

@jahirfiquitiva
Copy link
Author

thanks for the suggestion @DenverCoder1 😀🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants