[node] pipeline callback should not be optional #67345
Unanswered
jhmen
asked this question in
Issues with a @types package
Replies: 2 comments
-
Thanks for the discussion about "node", some useful links for everyone: Pinging the DT module owners: @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Fixed in #69498 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In the types for the node pipeline function (stream) the callback is marked as optional, but Node requires a callback or it will throw an error.
I have created a reproduce repo here: https://github.com/jhmen/pipeline-wrong-typing. If you ran this, you will get the error: ERR_INVALID_ARG_TYPE. But no typescript errors.
The solution would be to mark the callback as not optional
Beta Was this translation helpful? Give feedback.
All reactions