Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is total request body size limit handled? #22

Open
funex opened this issue Jan 14, 2023 · 5 comments
Open

Is total request body size limit handled? #22

funex opened this issue Jan 14, 2023 · 5 comments

Comments

@funex
Copy link

funex commented Jan 14, 2023

According to the API documentation:

"The total request body size must not exceed 128 KiB (128 · 1024 bytes). Please split up your text into multiple calls if it exceeds this limit."

Is this handled currently?

@daniel-jones-deepl
Copy link
Member

Hi @funex Pelican George, thanks for the question, sorry that this reply is so delayed.

No, this .NET client library does not split the text automatically.

@daniel-jones-deepl
Copy link
Member

Reopened to check whether it does make sense to implement this.

@funex
Copy link
Author

funex commented Feb 7, 2023

Would be great to add this feature since the request body max size is 1024 bytes. With the current version it's not possible to inspect the request body to decide if the texts to translate should be split in multiple requests. It is of course possible to get the byte count of the texts before translating, but the byte count won't be precise, in relation to the body size.

@JanEbbing
Copy link
Member

Hey @funex , we are looking at a way to support very large requests, but can't give any timeline or make any promises at the moment.
In the meantime, we suggest limiting your text to be translated to a limit slightly below the 128kB total request limit, for example 120kB or 115kB, that way you should never get rejected for a too large request.
I'm leaving the issue open until we have closure.

@butcher-07
Copy link

Hey @JanEbbing , is there any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants