New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CID: Remove prints, some small cleanup+type hints #433

Merged

DavidoTek merged 2 commits into DavidoTek:main from sonic2kk:small-cid-cleanup

Jul 31, 2024

Contributor

sonic2kk commented Jul 28, 2024 •

edited

Loading

For #432 I was in and around the code for the Custom Install Dialog and found a couple of spots where I could make some changes.

Remove unnecessary prints
Add type hints for a couple of potentially ambiguous scenarios (not sure if we want to go all the day with the hints here, just added it for places where it might not be immediately obvious, mainly the os.path.expanduser calls)
Reworked set_selected_launcher to be less nested ("Flat is better than nested" 😉)
Refactor + Type Hint for util#get_combobox_index_by_value to be less nested`


          CID: Remove prints, some small cleanup+type hints

57d9cc2

sonic2kk marked this pull request as draft

July 28, 2024 18:47


          CID: inline index assignment

763d4d9

sonic2kk marked this pull request as ready for review

July 28, 2024 18:56

DavidoTek merged commit cb0cd82 into DavidoTek:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet