Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scalafix to fix up the generated APIs #4

Open
DavidGregory084 opened this issue Apr 4, 2018 · 0 comments
Open

Use scalafix to fix up the generated APIs #4

DavidGregory084 opened this issue Apr 4, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@DavidGregory084
Copy link
Owner

DavidGregory084 commented Apr 4, 2018 •
edited
Loading

The APIs that are generated are a huge improvement for the most part in that they replace callbacks with Task.

However, I think we can do better, especially if we can use scalafix (in conjunction with refined?) to rewrite them in repeatable way.

Ideas include:

  • Banishing the many Strings and Ints in favour of more precise types like String Refined Url and Int Refined Positive
  • Wrapping side-effecty things in Task.eval
@DavidGregory084 DavidGregory084 added the enhancement New feature or request label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidGregory084