Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspicious line to output ViewHelper content #61

Open
schams-net opened this issue Feb 25, 2019 · 1 comment
Open

Suspicious line to output ViewHelper content #61

schams-net opened this issue Feb 25, 2019 · 1 comment

Comments

@schams-net
Copy link

The following line in Mittwald\Typo3Forum\ViewHelpers\Post\HelpfulButtonViewHelper, method render() looks suspicious:

$btn = '<div data-toogle="tooltip" title="' . $title . '" data- class="' . $class . '" data-countusertarget="' . $countUserTarget . '" data-counttarget="' . $countTarget . '" data-post="' . $post->getUid() . '" data-pageuid="' . $this->settings['pids']['Forum'] . '" data-eid="' . $this->settings['forum']['post']['helpfulBtn']['eID'] . '"></div>';
  • I don't know which JS library is used, but is data-toogle correct?
    Maybe it should read data-toggle?
  • The space between data- and class also looks suspicious.
@DavidBruchmann
Copy link
Owner

I never found any usage of data-class but in Public/Javascript/forum.js some data attributes are used.
The whole JS seems being outdated especially as jquery 1.10 is still used.
I think there might be some mess too perhaps, so someone spending some time on it and removing unused things too is welcome ;-)
One question is if we leave functionality or if there shall be something added i.e. modal-windows, but the best would be anyway having a simple basic theme and for additional features further theme(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants