Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose : support Amazon EventBridge Scheduler tracing. #2701

Open
mugioka opened this issue May 20, 2024 · 3 comments
Open

propose : support Amazon EventBridge Scheduler tracing. #2701

mugioka opened this issue May 20, 2024 · 3 comments
Assignees
Labels
ack waiting-for-info waiting for answer from issue creator

Comments

@mugioka
Copy link

mugioka commented May 20, 2024

I use the Amazon EventBridge Scheduler client(https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/scheduler) to create an Amazon EventBridge Schedule. It would be very nice to be able to trace those actions there.

Some logic may be needed here.

@mugioka mugioka added the enhancement quick change/addition that does not need full team approval label May 20, 2024
@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label May 20, 2024
@darccio darccio added proposal more in depth change that requires full team approval and removed enhancement quick change/addition that does not need full team approval labels Jun 3, 2024
@felixge felixge removed the needs-triage New issues that have not yet been triaged label Jun 6, 2024
@felixge
Copy link
Member

felixge commented Jun 6, 2024

Thanks for the suggestions, I've raised this with the team owning this. I hope they'll get back to you shortly with an update. Sorry for the delay.

@zarirhamza zarirhamza changed the title propose : suuport Amazon EventBridge Scheduler tracing. propose : suport Amazon EventBridge Scheduler tracing. Jun 6, 2024
@zarirhamza zarirhamza changed the title propose : suport Amazon EventBridge Scheduler tracing. propose : support Amazon EventBridge Scheduler tracing. Jun 6, 2024
@rarguelloF
Copy link
Contributor

Hello @mugioka - thanks for opening this issue.

The existing aws/aws-sdk-go and aws/aws-sdk-go-v2 should be sufficient to get tracing for any AWS service you are using, as they trace the underlying http client.

A very basic example would be:

package main

import (
	"context"
	"fmt"
	"log"

	awscfg "github.com/aws/aws-sdk-go-v2/config"
	"github.com/aws/aws-sdk-go-v2/service/scheduler"

	awstrace "gopkg.in/DataDog/dd-trace-go.v1/contrib/aws/aws-sdk-go-v2/aws"
)

func ExampleScheduler() {
	awsCfg, err := awscfg.LoadDefaultConfig(context.Background())
	if err != nil {
		log.Fatal(err)
	}
	awstrace.AppendMiddleware(&awsCfg)
	client := scheduler.NewFromConfig(awsCfg)
	out, err := client.ListSchedules(context.Background(), &scheduler.ListSchedulesInput{})
	if err != nil {
		log.Fatal(err)
	}
	fmt.Println(out)
}

Please let me know if this solves your issue.

@rarguelloF rarguelloF added ack waiting-for-info waiting for answer from issue creator and removed proposal more in depth change that requires full team approval labels Jun 6, 2024
@mugioka
Copy link
Author

mugioka commented Jun 7, 2024

Thank you for your reply.
I see.
I will try this and if this issue is solved let you know that this issue solved.

@rarguelloF rarguelloF self-assigned this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack waiting-for-info waiting for answer from issue creator
Projects
None yet
Development

No branches or pull requests

4 participants