Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download current RPM key" task runs invariably. #474

Open
thetic opened this issue Mar 1, 2023 · 3 comments · Fixed by #475
Open

"Download current RPM key" task runs invariably. #474

thetic opened this issue Mar 1, 2023 · 3 comments · Fixed by #475

Comments

@thetic
Copy link
Contributor

thetic commented Mar 1, 2023

Downloads to /tmp/ are not idempotent.

- name: Download current RPM key
get_url:
url: "{{ datadog_yum_gpgkey_current }}"
dest: /tmp/DATADOG_RPM_KEY_CURRENT.public
force: yes

@thetic
Copy link
Contributor Author

thetic commented Mar 1, 2023

rpm_key can accept a URL rather than a local path.

@KevinFairise2
Copy link
Contributor

Hi,
Sorry for the inconvenience but we had to revert #475 because it created a regression.
Merging this PR broke all the playbooks ran with variables datadog_yum_gpgkey_* set to local file with file:/// prefix, because rpm_key module does not allow importing key on the local file system with file:/// prefix.

We will look for another solution that would definitely solve this issue without breaking key import when using path to keys on the local file system.

@eightnoneone
Copy link

Why not just change the download destination to a non-tmp location or at least remove the force?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants