Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from raw::RDTimeStamp to double, remove unnecesary code in the detsim stage #41

Closed
jroto opened this issue Oct 26, 2023 · 2 comments
Closed

Change from raw::RDTimeStamp to double, remove unnecesary code in the detsim stage #41

jroto opened this issue Oct 26, 2023 · 2 comments
Assignees
@mantheys

Comments

@jroto
Copy link
Member

jroto commented Oct 26, 2023

Following this issue:
LArSoft/lardataobj#37

larcore has been changed in order to change in recob::OpWaveform the timestamp data member from raw::RDTimeStamp to double:
LArSoft/lardataobj#40

We should adapt the modules using OpWaveform, and remove unnecessary code that was used to deal with this type mismatch.
@jroto
Copy link
Member Author

jroto commented Oct 26, 2023

@maridelg

@jroto jroto mentioned this issue Sep 25, 2024
Merged
@jroto
Copy link
Member Author

jroto commented Oct 3, 2024

I close the issue, since it was solved in #62

@jroto jroto closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mantheys mantheys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jroto @mantheys