Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of code compliance issues #75

Open
jcfreeman2 opened this issue Aug 6, 2021 · 1 comment
Open

Couple of code compliance issues #75

jcfreeman2 opened this issue Aug 6, 2021 · 1 comment

Comments

@jcfreeman2
Copy link
Contributor

Running dbt-build.sh with the --lint argument as well as looking at some of the code, there are some improvements which could be made:

  • A lot of the files in trigger don't have our standard copyright message
  • As a collection of public data, Set.hpp is more properly a struct than a class
  • In general, no-op virtual destructor definitions ("virtual ~MyClass() {}") would be better declared default ("virtual ~MyClass() = default") if for no other reason than to not fool the linter into thinking the destructor is nontrivial (for more though, see here)

Other minor issues (and a couple of false positives, unfortunately) can also be unearthed via --lint

@ArturSztuc
Copy link
Contributor

@jcfreeman2 I wanted to have a look into this and close this old issue, but dbt-build --lint doesn't work for me as expected:
It does print the Package to lint is ... messages, and it generates the linting__DATE__ folder with logs for individual packages, but they are all empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants