Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanorc should be tested with 1 and 2 subsystems #19

Open
plasorak opened this issue Apr 26, 2022 · 2 comments
Open

Nanorc should be tested with 1 and 2 subsystems #19

plasorak opened this issue Apr 26, 2022 · 2 comments
Assignees

Comments

@plasorak
Copy link
Contributor

When testing nanorc, one should generate 2 configurations, create a top_level.json and run the RC with it, because some problems only appear when running with 2 subsystem configurations (we run with this at np04: wibs and daq).

@bieryAtFnal
Copy link
Contributor

I agree with the sentiment of this Issue completely. However, it would be helpful to understand a few details before we implement anything.

  • what was the problem that this integration test would have caught? (It would be helpful to know what that was so that we can be sure to address it in the test.)
  • do you have a suggestion for what to use for the second configuration? At the moment, I only know of WIBs as a possible source of that second config. Are there other options?

Thanks,
Kurt

@plasorak
Copy link
Contributor Author

I think in this case, we could have caught that subsystem can't be booted in parallel, and need to be booted sequentially, due to a rich error. The change that introduced this "feature" was the FSM. This morning I also realised that even specifying an order for subsystem wouldn't do.
For the second configuration, a duplicate of DAQ would work, or listrev. However, the tricky thing here is it needs some manual changes in the boot.json, otherwise one gets port clashes (and they cannot be sorted by partition-number, at least as it is now).

@glehmannmiotto glehmannmiotto self-assigned this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants