Johnfreeman/issue31 developer rules #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 5, 2023 17:24
… homepage of our documentation
jcfreeman2
requested review from
glehmannmiotto,
alessandrothea,
dingp and
bieryAtFnal
glehmannmiotto
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see what I've written re: communication rules, the relevant page is https://dune-daq-sw.readthedocs.io/en/johnfreeman-issue31_developer_rules/developer_rules/, but then see also how I link to it from near the top of the documentation homepage: https://dune-daq-sw.readthedocs.io/en/johnfreeman-issue31_developer_rules/. Please let me know if you think anything is too strict/not strict enough, or if you have any other comments.