Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags with white part should get a border #2537

Closed
vmcj opened this issue May 10, 2024 · 0 comments · Fixed by #2580
Closed

Flags with white part should get a border #2537

vmcj opened this issue May 10, 2024 · 0 comments · Fixed by #2580
Labels
good first issue web interface

Comments

@vmcj
Copy link
Member

vmcj commented May 10, 2024

See:
Screenshot from 2024-05-10 13-19-55

The Adam teams flag gets lost against the background.
@mpsijm mpsijm mentioned this issue May 28, 2024
Merged
mpsijm added a commit to mpsijm/domjudge that referenced this issue May 28, 2024
@mpsijm
DOMjudge#2537 Give flags a shadow, to make the white parts visible
55092cd
@mpsijm mpsijm mentioned this issue May 28, 2024
Merged
mpsijm added a commit to mpsijm/domjudge that referenced this issue May 29, 2024
@mpsijm
DOMjudge#2537 Give flags a ring-shadow, to make the white parts visible
2e149cb 
The idea of the ring-shadow is based on https://tailwindcss.com/docs/ring-width
Using this instead of a border, to make sure the ratio of the flag is maintained,
because CSS counts a border as part of the width/height.
github-merge-queue bot pushed a commit that referenced this issue May 30, 2024
@mpsijm @meisterT
#2537 Give flags a ring-shadow, to make the white parts visible
dcb690a 
The idea of the ring-shadow is based on https://tailwindcss.com/docs/ring-width
Using this instead of a border, to make sure the ratio of the flag is maintained,
because CSS counts a border as part of the width/height.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2537 Give flags a ring-shadow, to make the white parts visible mpsijm/domjudge
1 participant
@vmcj