Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flamethrower message not accurate if -Q option is passed #61

Open
leshow opened this issue Feb 21, 2021 · 1 comment
Open

flamethrower message not accurate if -Q option is passed #61

leshow opened this issue Feb 21, 2021 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@leshow
Copy link

leshow commented Feb 21, 2021

❯ flame 0.0.0.0 -p 9953 -Q 10   
flaming target "0.0.0.0" (0.0.0.0) on port 9953 with 10 concurrent generators, each sending 10 queries every 1ms on protocol udp

"10 concurrent generators, each sending 10 queries every 1ms on protocol udp" is not accurate if flamethrower is only sending 10 queries per second, 10 generators * 10 queries/ms is 100,000 QPS. Unless I'm missing something here, this message should change based the -Q parameter?

@weyrick
Copy link
Contributor

weyrick commented Feb 22, 2021

Interesting, yes I can see how that's confusing. It's actually not inaccurate - the rate limiting with -Q is applied at the end of the "pipeline", so indeed all of those generators are sending queries at the advertised rate and then they are limited to 10 QPS. I will flag this as a bug to make the message clearer. Thanks for the report!

@weyrick weyrick added the bug Something isn't working label Feb 22, 2021
@weyrick weyrick added this to To do in Public Work Board Apr 1, 2021
@weyrick weyrick added the good first issue Good for newcomers label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants