-
|
When I use the two parameters simultaneously, I noticed that the program first applies the limit and then the filter, filtering within the sub-items. This causes a problem where there are enough items, but they cannot be displayed. This order seems illogical. Should we adjust the execution sequence? |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 4 replies
-
|
1 1 1 1 2 2 2 1 1 1 1, limit=5 filter=1, ret is ['1,1,1,1'] |
Beta Was this translation helpful? Give feedback.
-
|
The order of processing common parameters is here. They're being processed from top to bottom. |
Beta Was this translation helpful? Give feedback.
-
|
I know that's the case. What I mean is that the project team has considered putting the limit after the filter？ |
Beta Was this translation helpful? Give feedback.
-
|
In other words, what were the considerations behind placing limit processing before filter? |
Beta Was this translation helpful? Give feedback.
-
|
The order is changed in a refactor(#3200). Filtering does come before limit before #3200 https://github.com/DIYgod/RSSHub/blame/a2600c4c7933fcc6a610a25458a839af48f020dd/lib/middleware/parameter.js. Feel free to submit a PR if you want to. |
Beta Was this translation helpful? Give feedback.
-
|
I'm very grateful for your reply. |
Beta Was this translation helpful? Give feedback.
The order is changed in a refactor(#3200). Filtering does come before limit before #3200 https://github.com/DIYgod/RSSHub/blame/a2600c4c7933fcc6a610a25458a839af48f020dd/lib/middleware/parameter.js. Feel free to submit a PR if you want to.