Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature names are ambiguous #48

Open
00sapo opened this issue Jan 25, 2023 · 2 comments
Open

Feature names are ambiguous #48

00sapo opened this issue Jan 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@00sapo
Copy link
Collaborator

00sapo commented Jan 25, 2023

To have clearly understandable names, we should define a specific format from which the largest number of information can be gathered. An easy way could be to call them according to a format like:

[module].[FirstOrder|SecondOrder].[Part|Score|Sound].[NameOfPartOrSoundOr-].[Boolean|Int|Float|String].[NameOfFeatureWithoutThePreviousStrings]

e.g.:

SoundVoice_Intervalm3_Per -> interval.2.Sound.Voice.Float.m3_per

where interval, Sound, and Voice are now more well-defined and consequently more meaningful, while 2 and Float are added

@martianbug martianbug changed the title Feature ames are ambiguous Feature names are ambiguous Jan 26, 2023
@martianbug
Copy link
Collaborator

mm yep, sounds like an improvement. Do u think its worth the efforto, or if data its gonna be more usable for data analysis?

@00sapo
Copy link
Collaborator Author

00sapo commented Jan 30, 2023

Not sure, but this would ultimately help the selection of certain features because it's a clearer format (users can define regex easily) and a better format for pandas API (it works well with multicolumns).

I would leave it here for remembering in future

@00sapo 00sapo added the enhancement New feature or request label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants