Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cargo binstall #552

Closed
liamwh opened this issue Nov 14, 2023 · 9 comments
Closed

Add support for cargo binstall #552

liamwh opened this issue Nov 14, 2023 · 9 comments

Comments

@liamwh
Copy link

liamwh commented Nov 14, 2023

As described here, so that cargo-binstall doesn't attempt to install cargo-cyclonedx from source:
image

@lfrancke
Copy link
Contributor

Are you willing or interested in providing a PR for this?

@tshepang
Copy link
Contributor

cargo-dist would make providing such extra easy

@ashleygwilliams
Copy link
Contributor

i was going to file an issue to add cargo-dist support and saw this one. cargo-dist is compatible with cargo-binstall and so would solve this plus a few other niceties including package manager distribution for easy install on ci (which is my motivation- we'd love to offer cyclonedx as an option in cargo-dist itself).

i am very happy to make a PR for this- just let me know!

@Shnatsel
Copy link
Contributor

I'd be happy to have a PR for it! We should also update the repo's README listing it as a possible installation option.

It'd be great to get a release workflow with cross going for building aarch64 binaries as well, but that's a separate issue (cc @keponk )

@ashleygwilliams
Copy link
Contributor

put a PR up- cargo-dist can add the release instructions to the release body- but i'm also happy to add the installers to the README once we decide which ones you want to support.

@ashleygwilliams
Copy link
Contributor

also, cargo-dist does the mac cross natively for you, so you'll at least have apple aarch64 binaries.

@liamwh
Copy link
Author

liamwh commented Nov 17, 2023

I've had a really great experience automating releases using release-plz. I believe it's even simpler than cargo-dist, although I don't have any firsthand experience with cargo-dist myself. However I can recommend using release-plz, I found it extremely easy to use and have no complaints with it. Maybe it's helpful here?

@ashleygwilliams
Copy link
Contributor

hey @liamwh - release plz is great and i think it can be a good tool for generating changelogs, but it doesn't have functionality for building standalone releases or generating installers. many folks use release-plz with cargo-dist for changelog generation. the main thing that cargo-dist is doing here is building binaries and then archiving those binaries for a variety of platforms, then generating installers for them.

@ashleygwilliams
Copy link
Contributor

i believe that this was solved by #727 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants