-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using packageurl::PackageUrl
instead of custom Purl
type.
#410
Comments
There is a downside to exposing For now we've instead exposed FromStr implementations for Purl in #381 to make it writable, but without actually transitioning to a foreign type. |
Alright, seems like a good enough solution. Do you think documentation could be added to more clearly indicate this is the recommended way to interoperate with the |
There are several package URL crates in use already. I don't think it makes sense to enumerate every one in the documentation. I'd be happy to accept a PR adding a code example that uses the |
Right now the crate uses its own
Purl
type, with only hidden fields (which also makes it not terribly useful as-is, except for validation; use of its contents requiresDisplay
-ing and then reparsing withpackageurl::PackageUrl
orurl::Url
anyway). It's probably better to transition this topackageurl::PackageUrl
to enable easier interoperation and enable extraction of the purl's components.The text was updated successfully, but these errors were encountered: