Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LicenseExpression's optional arguments should be named arguments #594

Open
jkowalleck opened this issue Apr 19, 2024 · 1 comment · Fixed by #595 · May be fixed by #665
Open

LicenseExpression's optional arguments should be named arguments #594

jkowalleck opened this issue Apr 19, 2024 · 1 comment · Fixed by #595 · May be fixed by #665
Assignees
@jkowalleck
Labels
breaking change bug Something isn't working
Milestone
8.0.0

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Apr 19, 2024 •
edited
Loading

current implementation has an architectural lock in:
LicenseExpression's optional arguments are positional arguments.
it would be better to have them as named arguments, so we could rearrange these arguments at will ...
@jkowalleck jkowalleck added the bug Something isn't working label Apr 19, 2024
@jkowalleck jkowalleck mentioned this issue Apr 19, 2024
Merged
jkowalleck added a commit that referenced this issue Sep 16, 2024
@jkowalleck
refactor!: LicenseExpression() optional args are named args (#595)
0172564 
fixes #594

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck linked a pull request Sep 16, 2024 that will close this issue
Open
@jkowalleck
Copy link
Member Author

implementation finished

@jkowalleck jkowalleck added this to the 8.0.0 milestone Sep 16, 2024
@jkowalleck jkowalleck self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
breaking change bug Something isn't working
Projects
None yet
Milestone
8.0.0
1 participant
@jkowalleck