Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#842 Add additional properties to SBOM #846

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

#842 Add additional properties to SBOM #846

wants to merge 6 commits into from

Conversation

thompson-tomo
Copy link

@thompson-tomo thompson-tomo commented Jan 29, 2024 •
edited

This request now sets:

  • the publisher in the sbom based on the owner and if it is null it will use the author

Closes #842

@thompson-tomo thompson-tomo mentioned this pull request Jan 29, 2024
Open
@mtsfoni
Copy link
Contributor

mtsfoni commented Jan 30, 2024

I'm not quite convinced the owner should be filled with the author. Can you explain your reasoning for it? Is it regarding some national regulations?

@thompson-tomo
Copy link
Author

@mtsfoni as per the nuspec reference on microsoft (https://learn.microsoft.com/en-us/nuget/reference/nuspec) owners is deprecated and instead should use authors moving forward.

@thompson-tomo
Code style changes
5472d5e 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo thompson-tomo marked this pull request as ready for review March 12, 2024 21:53
@thompson-tomo thompson-tomo requested a review from a team as a code owner March 12, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set additional properties when generating sbom for nugets
2 participants
@thompson-tomo @mtsfoni