Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a folder path as entry point instead of Project/Solution files #728

Open
hornpecom opened this issue Jun 29, 2023 · 4 comments
Open

Comments

@hornpecom
Copy link

hornpecom commented Jun 29, 2023

Suggestion: Use a folder path as entry point instead of Project/Solution files

recursively search in the folder for the following files

  • project.assets.json
    or
  • packages.lock.json

Background: Our MSBuild based build scripts are not in the solution and are not taken into account in the dependency scan. Although they also use NuGet Packages which would be relevant for the SBOM

I'm sure the JSON files approach can simplify the whole process pretty much. Because there is no need for a time-consuming search for the dependencies via the project/solution files or the build for the scan of the dependencies could be omitted entirely. A single requirement of the scan can be the existence of the mentioned json files. It doesn't matter how they come about

@rkg-mm
Copy link

rkg-mm commented Jul 5, 2023

Or use a glob statement that can match e.g. **/*.csproj oder others like some build tools support

@hornpecom
Copy link
Author

@rkg-mm The json file approach is a bit better because I could split my build pipeline into Build Job and SBOM Job.
These JSON files are created during the build anyway and
can be transferred to the SBOM job as artifacts. The SBOM job only creates SBOM based on the JSON files

@Bertk
Copy link
Contributor

Bertk commented Aug 15, 2023

Please note: CycloneDX tool is using solution and C# project files to gather meta data e.g. IsTestProject .
Generated project.assets.json files are used to identify the dependencies of the C# project files.

Unfortunately, it does not support an array of C# project files. Maybe this would be helpful for you.

@mtsfoni
Copy link
Contributor

mtsfoni commented Dec 13, 2023

Background: Our MSBuild based build scripts are not in the solution and are not taken into account in the dependency scan. Although they also use NuGet Packages which would be relevant for the SBOM

I need some more detailed information here. I don't understand how or why you need to add components at compile time that are not yet known at design time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants