-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github license resolution fails for repos not using "master" #432
Comments
Thanks for raising the issue. We should probably be checking what the default branch is first and just using that. I'm starting to work on the next major version. So I'll probably lump it in with that unless someone else wants to create a PR in the meantime. |
You know, actually - I was looking deeper into the code so that I could see whether I could tackle a PR for it, and it looks like you just ignore references that aren't So that would mean there's still an issue in that it should accept |
Main problem could be fixed with: #515. But all other branches besides main and master won't be fixed with that. |
…l field. Fixes CycloneDX#432 and CycloneDX#489. Signed-off-by: Erick Caisse <[email protected]>
…l field. Fixes CycloneDX#432 and CycloneDX#489. Signed-off-by: Erick Caisse <[email protected]>
This issue is stale because it has been open for 3 months with no activity. |
As lots of repos have now moved away from calling the default branch "master", this library fails Github license resolution for those libraries now. Perhaps the support ticket referenced in the code will get fixed, but if not it might be worth failing once and trying "main" too.
The text was updated successfully, but these errors were encountered: