From 3dd8701beb3f5569b596a1d4458345a74f59dfb6 Mon Sep 17 00:00:00 2001 From: xgorse Date: Mon, 16 Mar 2015 21:40:55 +0100 Subject: [PATCH 1/2] Add angulartics --- bower.json | 1 + gulpfile.js | 4 +++- src/client/app.js | 2 +- src/client/views/rooms/list.html | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/bower.json b/bower.json index 794030fc..085fa8ae 100644 --- a/bower.json +++ b/bower.json @@ -34,6 +34,7 @@ "angular": "~1.3.*", "angular-route": "~1.3.*", "angular-cookies": "~1.3.*", + "angulartics": "0.17.*", "createjs-soundjs": "0.6.*", "angular-bootstrap-colorpicker": "~3.0.*" }, diff --git a/gulpfile.js b/gulpfile.js index 03cc3406..0235dbf7 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -35,7 +35,9 @@ var fs = require('fs'), './bower_components/tom32i-option-resolver.js/dist/option-resolver.min.js', './bower_components/tom32i-gamepad.js/dist/gamepad.min.js', './bower_components/tom32i-key-mapper.js/dist/key-mapper.min.js', - './bower_components/tom32i-asset-loader.js/dist/asset-loader.min.js' + './bower_components/tom32i-asset-loader.js/dist/asset-loader.min.js', + './bower_components/angulartics/dist/angulartics.min.js', + './bower_components/angulartics/dist/angulartics-ga.min.js' ], recipes = { server: require('./recipes/server.json'), diff --git a/src/client/app.js b/src/client/app.js index bea32b2e..d17a5514 100644 --- a/src/client/app.js +++ b/src/client/app.js @@ -1,4 +1,4 @@ -var curvytronApp = angular.module('curvytronApp', ['ngRoute', 'ngCookies', 'colorpicker.module']), +var curvytronApp = angular.module('curvytronApp', ['ngRoute', 'ngCookies', 'colorpicker.module','angulartics', 'angulartics.google.analytics']), gamepadListener = new GamepadListener({analog: false, deadZone: 0.4}); gamepadListener.start(); diff --git a/src/client/views/rooms/list.html b/src/client/views/rooms/list.html index 55411747..8f19c9d6 100644 --- a/src/client/views/rooms/list.html +++ b/src/client/views/rooms/list.html @@ -29,7 +29,7 @@

/>
- From 1ee59b42b8b8613411fc705240ebfe9cef4364cb Mon Sep 17 00:00:00 2001 From: xgorse Date: Mon, 16 Mar 2015 22:22:14 +0100 Subject: [PATCH 2/2] Desactivate old and direct ga() call --- src/client/service/Analyser.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/client/service/Analyser.js b/src/client/service/Analyser.js index beac00d3..76009c09 100644 --- a/src/client/service/Analyser.js +++ b/src/client/service/Analyser.js @@ -81,8 +81,8 @@ Analyser.prototype.getTitle = function(controller, params) */ Analyser.prototype.sendPageView = function(page, title) { - ga('send', 'pageview', { - page: page, - title: title - }); + // ga('send', 'pageview', { + // page: page, + // title: title + // }); };