Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python/OS compatibility #71

Closed
ubmarco opened this issue May 6, 2024 · 3 comments
Closed

Python/OS compatibility #71

ubmarco opened this issue May 6, 2024 · 3 comments

Comments

@ubmarco
Copy link

ubmarco commented May 6, 2024

Thanks for this library. I'm using it in a pants project, but when building a pex I get

No pre-built wheel was available for licensing 0.45.
Successfully built the wheel licensing-0.45-py3-none-any.whl from the sdist licensing-0.45.tar.gz but it is not compatible with the requested foreign target complete platform cp311-cp311-manylinux_2_35_x86_64.
You'll need to build a wheel from licensing-0.45.tar.gz on the foreign target platform and make it available to Pex via a `--find-links` repo or a custom `--index`.

I think this due to the classifiers in setup.py:

    'Programming Language :: Python :: 3',      #Specify which pyhton versions that you want to support
    'Programming Language :: Python :: 3.4',
    'Programming Language :: Python :: 3.5',
    'Programming Language :: Python :: 3.6',

What about 3.7 to 3.12, are they also supported? What about the OS specifiers, does it support all OS's?

@ubmarco ubmarco changed the title Python compatibility Python/OS compatibility May 6, 2024
@ubmarco
Copy link
Author

ubmarco commented May 6, 2024

This is the PKG-INFO of the 0.45 sdist:

Metadata-Version: 1.1
Name: licensing
Version: 0.45
Summary: Client library for Cryptolens licensing Web API.
Home-page: https://cryptolens.io
Author: Cryptolens AB
Author-email: [email protected]
License: MIT
Download-URL: https://github.com/Cryptolens/cryptolens-python/archive/v_45.tar.gz
Description: UNKNOWN
Keywords: software licensing,licensing library,cryptolens
Platform: UNKNOWN
Classifier: Intended Audience :: Developers
Classifier: Topic :: Software Development :: Build Tools
Classifier: License :: OSI Approved :: MIT License
Classifier: Programming Language :: Python :: 3
Classifier: Programming Language :: Python :: 3.4
Classifier: Programming Language :: Python :: 3.5
Classifier: Programming Language :: Python :: 3.6

artemlos added a commit that referenced this issue Aug 14, 2024
@artemlos
Copy link
Contributor

@ubmarco Thank you for pointing this out. I'm sorry for not have replied earlier. A few changes were made to the setup.py in a481e3d that should hopefully resolve this. Firstly, the list of Python versions was extended. Secondly, a list of supported platforms was added. I think the issue could have been caused by the latter, since we already specify that the package works with Python 3, however, all the versions are now explicitly specified.

@artemlos
Copy link
Contributor

A new release is now available which should address the issue caused by missing Python versions.

@ubmarco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants