Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

woff broken? #20

Open
ForbiddenEra opened this issue Nov 9, 2022 · 4 comments
Open

woff broken? #20

ForbiddenEra opened this issue Nov 9, 2022 · 4 comments

Comments

@ForbiddenEra
Copy link

ForbiddenEra commented Nov 9, 2022

If I let the woff load instead of others, I get different icons..?

image

supposed to be eth, bnb, matic.. but shows others?

also, any chance for woff2?

also also would be awesome if we could generate a set based off prefs.. if only using a few, would be nice to have smaller package for client

tyvm!

@monzanifabio
Copy link
Member

Hey @ForbiddenEra thank you for pointing this out.
Let me investigate.
Are you using a version from the CDN or are you hosting the latest version yourself?

Regarding your idea, we have been thinking of something like that :)

@monzanifabio monzanifabio closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2022
@ForbiddenEra
Copy link
Author

Hey @ForbiddenEra thank you for pointing this out. Let me investigate. Are you using a version from the CDN or are you hosting the latest version yourself?

Regarding your idea, we have been thinking of something like that :)

I'm hosting myself, I prefer to reduce and if i I can, remove any references to external sites on my site as it tends to improve performance (though, readers should understand this isn't true in every case due to the amount of crazy optimization many CDN providers have) by not requiring a client to do DNS lookups and open connections to multiple servers.

While I'm here, IIRC the Polygon logo was saved as MATIC, wonder if this could/should be updated to POLY since that seems to be the direction they're taking; mainly I want to keep names consistent throughout my project(s) and otherwise we've used Poly because, as I just mentioned, that seems to be the direction they've tended towards.

Perhaps, if not wanting to break compatibility for other users as well, a symlink could be used.

And definitely +10 for choosing glyphs for smaller package sizes! One can define/limit the glyphs they want to use in CSS but I can't think of any way that could help reduce network transfer size unless somehow the http server was aware to only serve portions or something - I think Google Fonts does something like this but the unicode ranges IIRC are also sent as a query string for the server to only serve the appropriate glyphs. Of course, this wouldn't (easily) work for anyone self-hosting unless they hosted the script that did this, however, if your CDN did this or there was some sort of generator for it then I could simply save that output for serving to my clients.

As I mentioned, at this time it's by far the largest asset in this particular project and I'm all about reducing whatever I can - if this becomes a feature, I think my entire app's client side including assets could be delivered in under 200kB, maybe less!

@ForbiddenEra
Copy link
Author

I also noticed this was Closed - Not Planned - if my initial issue isn't a bug somehow, can you at all clarify why I saw different glyphs with the only change being the browser using the wof instead of any of the other types..?

@monzanifabio
Copy link
Member

I think it was closed due to inactivity since some time has passed from your previous comment.
Regarding the polygon naming, we are sticking to the ticker name that is also used elsewhere like Coingecko etc.
If they are going to change to poly we would gladly update that.
Regarding reducing size, we are working on a large release for v3 that would mainly be svg based meaning that the font would become of secondary use since the more icons we add the bigger the size becomes.
Also instead of names and tickers, we should be using contract addresses to resolve issues where multiple coins share the same ticker.

@monzanifabio monzanifabio reopened this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants