Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use of role for MenuItem #122

Open
scope2229 opened this issue Sep 7, 2022 · 0 comments
Open

Support use of role for MenuItem #122

scope2229 opened this issue Sep 7, 2022 · 0 comments

Comments

@scope2229
Copy link

scope2229 commented Sep 7, 2022

If you use Electron MenuItem role option the error Uncaught TypeError: MenuItem must have at least one of label, role or type is thrown.

To reproduce inside the example instead of using the defaultMenu with TitleBar menu option use the following code

[
    {
      label: 'Menu',
      submenu: [
        {
          id: 'file',
          label: 'File',
          click: () => console.log("File"),
        },{
          role: "editMenu"
        }
      ],
    },
  ]

I think the role needs adding to the MenuItem type along with check the inside validate() not sure what else would be required though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant