Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CancelledPacketHandleException: null #547

Open
andrewkm opened this issue Apr 1, 2023 · 5 comments
Open

CancelledPacketHandleException: null #547

andrewkm opened this issue Apr 1, 2023 · 5 comments
Assignees
Labels
priority: normal An issue of normal importance type: bug

Comments

@andrewkm
Copy link

andrewkm commented Apr 1, 2023

Paper 1.19.4 Build 484
CrazyCrates compiled against 2417a0e

Just witnessed a user do the following:

[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast lost connection: Kicked for spamming
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine

All within the same second.
When questioned, he stated he had the command on a macro while in a minecart.

Immediately after the console literally blew up as such:
https://pastebin.com/raw/eqDEDhyJ

This spam continued for a good 3-5 minutes before it finally stopped.

@TrueDarkLord
Copy link
Contributor

Paper 1.19.4 Build 484 CrazyCrates compiled against 2417a0e

Just witnessed a user do the following:

[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast lost connection: Kicked for spamming
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine
[21:54:49] [Server thread/INFO]: TescosToast issued server command: /cc open starmachine

All within the same second. When questioned, he stated he had the command on a macro while in a minecart.

Immediately after the console literally blew up as such: https://pastebin.com/raw/eqDEDhyJ

This spam continued for a good 3-5 minutes before it finally stopped.

Use external plugins or base server features to limit packets, and to make it even better, limit the overall command and messages that can be sent in a specified amount of time.

@andrewkm
Copy link
Author

andrewkm commented Apr 1, 2023

We already limit packets and commands, I've been attempting to reproduce with macros of my own and cannot, I have no idea how they managed to do this.

They mentioned they saw the "crate already open" message, perhaps something glitched out and ran them all at once.

None the less if a fix isn't planned for this we can fork and figure it out.

@ryderbelserion
Copy link
Member

well, better late than never

@ryderbelserion
Copy link
Member

ryderbelserion commented Sep 30, 2023

I'll add a cooldown option for commands, would that be enough?

@andrewkm
Copy link
Author

Sure that would be nice :)
I closed it as I was just going over all my authored github issues to clean them up a bit, and haven't had this happen again since the report so figured it was fixed.

@ryderbelserion ryderbelserion changed the title CancelledPacketHandleException: null [Bug Report] CancelledPacketHandleException: null Apr 13, 2024
@ryderbelserion ryderbelserion self-assigned this Apr 13, 2024
@ryderbelserion ryderbelserion added priority: normal An issue of normal importance type: bug labels Apr 13, 2024
@ryderbelserion ryderbelserion changed the title [Bug Report] CancelledPacketHandleException: null CancelledPacketHandleException: null Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal An issue of normal importance type: bug
Projects
No open projects
Status: Needs Work
Development

No branches or pull requests

3 participants