Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast FourierKernel._convolve_volume #974

Open
garrettwrong opened this issue Jul 13, 2023 · 0 comments
Open

Broadcast FourierKernel._convolve_volume #974

garrettwrong opened this issue Jul 13, 2023 · 0 comments
Labels
cleanup enhancement New feature or request Optimization Performance or Resource Optimzation

Comments

@garrettwrong
Copy link
Collaborator

During #406, it was noted that it should be straightforward to broadcast _convolve_volume instead of iterating. Right now it is almost generalized.

We'll just need to be careful about memory usage... Can consider a parameterized batch size, maybe defaulting to something based on voxels*volumes. Should double check whether the speedup is worth it first.

In the case it isn't, the code could be cleaned up (rm singleton branches etc).

@garrettwrong garrettwrong added enhancement New feature or request cleanup Optimization Performance or Resource Optimzation labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement New feature or request Optimization Performance or Resource Optimzation
Projects
None yet
Development

No branches or pull requests

1 participant