Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relion now uses rlnOriginX(Y)Angstrom instead of rlnOriginX(Y) #1118

Open
j-c-c opened this issue May 22, 2024 · 2 comments
Open

Relion now uses rlnOriginX(Y)Angstrom instead of rlnOriginX(Y) #1118

j-c-c opened this issue May 22, 2024 · 2 comments
Labels
bug Something isn't working extern Relating to external changes

Comments

@j-c-c
Copy link
Collaborator

j-c-c commented May 22, 2024

Newer versions of Relion use Angstrom values for image offsets instead of pixels (see docs). The Relion metadata name has also been changed to rlnOriginX(Y)Angstrom. This causes an error if a user saves an ImageSource in ASPIRE and attempts to open the starfile in Relion, as the name rlnOriginX(Y) is not recognized.

@j-c-c j-c-c added bug Something isn't working extern Relating to external changes labels May 22, 2024
@garrettwrong
Copy link
Collaborator

I'm sort of suprised they don't admit the old attributes or allow opening an older format file. I would think this would be a pain for them (unable to open their own files from a prior save...?).

Before getting too far, for a quick fix, it would be good to check that this isn't resolved my saving with a format/version attribute (that we are presumably missing).

I say that because while the right thing to do is to move toward >=3.1 attributes, a complication there is this will require pixel size in the base ImageSource class (or manually at save, annoying for devs), and in a way that doesn't clash with things that input/operate with ImageSource (filters etc). This issue probably will require more code reading/planning than it seems superficially.

@garrettwrong
Copy link
Collaborator

We have pixel size thread through our classes now. @j-c-c , maybe consider picking this up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extern Relating to external changes
Projects
None yet
Development

No branches or pull requests

2 participants