Replies: 4 comments 1 reply
-
I wholeheartedly agree. Benefit of automation is also it's a matter-of-fact action, because it's not a live person closing the PR :) For my brain, it's much easier to accept. |
Beta Was this translation helpful? Give feedback.
-
I support this automation. Manual work in this matter is laborious and inactive PRs also cause distractions for maintainers. |
Beta Was this translation helpful? Give feedback.
-
I'm not fully behind this type of automation. I do seen the benefits, but I'm not fully convinced the benefits will out weight the costs to the project. My first concern is the use of junk comments to keep the PR open. There might solutions around this. I'm not fully convinced of the distraction that old PRs cause. I personally when I see this type of automation on other project I think that the maintainers are arrogant. If you don't have a lot time to work on PR and some bot closes because you were busy can be deeply demotivating. Also closing PRs because the CODEOWNERs just didn't get around to reviewing it in time seems punitive on the wrong person. If we do end up doing this I would propose automated closing after 45 days or more, not 30. The word "should" was chosen for reason over "must" or "shall" in this section. This will give time for our community who may not work full time on there contributions. |
Beta Was this translation helpful? Give feedback.
-
In general I agree with automation, but I hear Matthew.
I get the point, at the other hand, nobody prevents you from reopening the PR.
I definitely agree. And probably this might be a linked point we should solve; maybe reviewers could get reminded when the PR is hanging there because of them? |
Beta Was this translation helpful? Give feedback.
-
The ComplianceAsCode Contribution Guidelines says:
The current practice is that when there is no activity (reply, comment, code change) for more than 30 days we are closing the PR. Closed PR can be reopened any time if the author still wants to work on it.
We propose to automate closing inactive PRs using https://github.com/marketplace/actions/close-stale-issues. Using the automation will remove manual work needed to detect and close inactive PRs.
Please express your opinions about this proposal.
Beta Was this translation helpful? Give feedback.
All reactions