[IncrementalLoadingCollection] is CancellationToken useful?

[HppZ]

No Cancel call with _cancellationToken, so is it necessary？

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp/IncrementalLoadingCollection/IncrementalLoadingCollection.cs

Lines 190 to 191 in 18b86b7

	public IAsyncOperation<LoadMoreItemsResult> LoadMoreItemsAsync(uint count)
	=> LoadMoreItemsAsync(count, new CancellationToken(false)).AsAsyncOperation();

[ghost]

Hello HppZ, thank you for your interest in Windows Community Toolkit!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible.. Other community members may also answer the question and provide feedback 🙌

[michael-hawker]

@HppZ FYI you can use the 'copy permalink' feature to link to the code in the repository directly and insert as a snippet so that we get direct context.

If you follow the code path, then you'll see it gets passed to the the LoadDataAsync and GetPagedItemsAsync methods which developers can override or implement on their source and then potentially cancel:

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp/IncrementalLoadingCollection/IncrementalLoadingCollection.cs

Lines 229 to 232 in 18b86b7

	protected virtual async Task<IEnumerable<IType>> LoadDataAsync(CancellationToken cancellationToken)
	{
	var result = await Source.GetPagedItemsAsync(CurrentPageIndex, ItemsPerPage, cancellationToken)
	.ContinueWith(

In this specific spot we could encapsulate the creation of the Token in the base private LoadMoreItemsAsync method I suppose, but it's not really a big deal at the moment. Maybe if we have something else to do on this class in the future.

It's probably a left-over implementation detail from some previous version of the class.

@RosarioPulella @XAML-Knight thoughts?

[HppZ]

How to cancel previous LoadMoreItemsAsync request if I call RefreshAsync multiple times in a short time?