Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenizingTextBox will Place New Tokens to Wrong Side in Some Cases #466

Open
2 of 24 tasks
ShimizuTheLotus opened this issue Aug 7, 2024 · 2 comments
Open
2 of 24 tasks
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed ux 🖌️ Everything design related

Comments

@ShimizuTheLotus
Copy link

ShimizuTheLotus commented Aug 7, 2024

Describe the bug

In some cases, the new tokens created will be placed at the right side of the input box.

Steps to reproduce

1. Create tokens like Pic 1.
2. Press shift and then select 1st ~ 3rd like Pic 2.
3. Press backspace and type, the coltrol will looks like Pic 3 and 4.

Expected behavior

No matter how to operate, the input box will still at the right side.

Screenshots

image

Pic 1

image

Pic 2

Screenshot 2024-08-07 165625

Pic 3

Screenshot 2024-08-07 165753

Pic 4

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

Windows 11 23H2 (Build 22635.3139)

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

No, I'm unable to contribute a solution.

@Arlodotexe Arlodotexe added bug Something isn't working help wanted Extra attention is needed ux 🖌️ Everything design related labels Sep 10, 2024
@Arlodotexe Arlodotexe moved this to 🆕 New in Toolkit 8.x Sep 10, 2024
@michael-hawker
Copy link
Member

I was able to reproduce this, it's expected to be able replace tokens with text, but them being added to the end here after is a bit odd. Hopefully should be a simple logic issue someone could maybe pick up easily.

@michael-hawker michael-hawker added the good first issue Good for newcomers label Sep 23, 2024
@AndrewKeepCoding
Copy link

Hi @michael-hawker!
I'd like to take look at this as my first good issue in this repo.

I've already cloned the repo, went through the instructions and ran the head project (WASDK) but when I do any changes (add token/remove token) to the TokeizingTextBox, I get the exception "Specified cast is not valid".

image

Might be related to #498 and #512. Is there any way to workaround this just to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed ux 🖌️ Everything design related
Projects
Status: 🆕 New
Development

No branches or pull requests

4 participants