Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Popup V2 #2434

Open
7 of 8 tasks
VladislavAntonyuk opened this issue Jan 10, 2025 · 0 comments · May be fixed by #1581
Open
7 of 8 tasks

[Proposal] Popup V2 #2434

VladislavAntonyuk opened this issue Jan 10, 2025 · 0 comments · May be fixed by #1581
Assignees
@VladislavAntonyuk
Labels
approved This Proposal has been approved and is ready to be added to the Toolkit champion A member of the .NET MAUI Toolkit core team has chosen to champion this feature enhancement New feature or request feature request 📬 in-progress proposal A fully fleshed out proposal describing a new feature in syntactic and semantic detail
Milestone
vNext

Comments

@VladislavAntonyuk
Copy link
Collaborator

VladislavAntonyuk commented Jan 10, 2025 •
edited
Loading

Feature name

Popup

Link to discussion

https://github.com/CommunityToolkit/Maui/wiki/2025-January-Standup

Progress tracker

  • Android Implementation
  • iOS Implementation
  • MacCatalyst Implementation
  • Windows Implementation
  • Tizen Implementation
  • Unit Tests
  • Samples
  • Documentation

Summary

Inspired by https://redth.codes/popups-with-net-maui-no-plugin-nuget-needed

Motivation

Remove handlers. Easier maintain the product.

Detailed Design

The new popup is based on the current PopupService implementation. We now require a new INavigation parameter to display a popup in the active window.

The Anchor feature is removed.

Usage Syntax

MyNavigation.ShowPopupAsync<T, TResult>(PopupOptions); (where T - PopupView, TResult is expected output type)
MyNavigation.ShowPopupAsync<T,>(PopupOptions); (where T - PopupView)

PopupService.ShowPopupAsync<T, TResult>(navigation, popupOptions)
PopupService.ShowPopupAsync<T>(navigation, popupOptions)

Drawbacks

No response

Alternatives

No response

Unresolved Questions

No response
@VladislavAntonyuk VladislavAntonyuk added new proposal A fully fleshed out proposal describing a new feature in syntactic and semantic detail labels Jan 10, 2025
@VladislavAntonyuk VladislavAntonyuk self-assigned this Jan 10, 2025
@VladislavAntonyuk VladislavAntonyuk added this to the vNext milestone Jan 10, 2025
@VladislavAntonyuk VladislavAntonyuk added enhancement New feature or request approved This Proposal has been approved and is ready to be added to the Toolkit champion A member of the .NET MAUI Toolkit core team has chosen to champion this feature in-progress feature request 📬 labels Jan 10, 2025
@VladislavAntonyuk VladislavAntonyuk linked a pull request Jan 15, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VladislavAntonyuk VladislavAntonyuk

Labels
approved This Proposal has been approved and is ready to be added to the Toolkit champion A member of the .NET MAUI Toolkit core team has chosen to champion this feature enhancement New feature or request feature request 📬 in-progress proposal A fully fleshed out proposal describing a new feature in syntactic and semantic detail
Projects
`CommunityToolkit.Maui` New Feature Proposals
Status: Proposal Approved
Milestone
vNext
Development

Successfully merging a pull request may close this issue.

Popup V2 CommunityToolkit/Maui
1 participant
@VladislavAntonyuk