Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppServices isn't updating in NuGet feed #623

Open
20 tasks
Arlodotexe opened this issue Dec 27, 2024 · 3 comments · Fixed by #626
Open
20 tasks

AppServices isn't updating in NuGet feed #623

Arlodotexe opened this issue Dec 27, 2024 · 3 comments · Fixed by #626
Assignees
Labels
bug 🐛 Something isn't working

Comments

@Arlodotexe
Copy link
Member

Arlodotexe commented Dec 27, 2024

Describe the bug

The latest update to our Labs NuGet feed saw a silent failure in the AppServices component, causing the component to not build or publish.

Steps to reproduce

From powershell with msbuild on PATH:

1. Run `.\tooling\Build-Toolkit-Components.ps1 -mt all -Components AppServices -bl -winui 2`
2. Observe error

Expected behavior

Component should have built and published.

Screenshots

Image

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

CommunityToolkit.AppServices.msbuild.zip

Help us help you

Yes, I'd like to be assigned to work on this item.

@Arlodotexe Arlodotexe added the bug 🐛 Something isn't working label Dec 27, 2024
@Sergio0694
Copy link
Member

Fixed the build in CommunityToolkit/Tooling-Windows-Submodule@3e178bc. However packaging now fails. Progress?

@Arlodotexe
Copy link
Member Author

The next error message here is:

       "V:\Labs-Windows\components\AppServices\src\CommunityToolkit.AppServices.csproj" (Build;Pack target) (1:23) ->
       (GenerateNuspec target) ->
         C:\Users\arlog\.nuget\packages\nuget.build.tasks.pack\6.12.1\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error : Could not find a part of the path 'V:\Labs-Windows\compo 
       nents\AppServices\CommunityToolkit.AppServices.SourceGenerators\bin\AnyCPU\Release\netstandard2.0'. [V:\Labs-Windows\components\AppServices\src\CommunityToolkit.AppServices.csproj]       

    15 Warning(s)
    1 Error(s)

To repro the error, run the build command normally in Labs:

./tooling/Build-Toolkit-Components.ps1 -MultiTargets all -Components AppServices -ExcludeMultiTargets wasdk -WinUIMajorVersion 2 -NupkgOutput ./ -Release -bl

Seems like the issue stems from this line:

<None Include="..\CommunityToolkit.AppServices.SourceGenerators\bin\$(Platform)\$(Configuration)\netstandard2.0\CommunityToolkit.AppServices.SourceGenerators.dll" PackagePath="analyzers\dotnet\cs" Pack="true" Visible="false" />

It's worth noting the actual content of the bin folder:
Image

Given this, there are two possible reasons why this declaration breaks:

  • This None declaration asks for bin\$(Platform)\$(Configuration), but the build is outputting bin\$(Configuration)\$(Platform)\
  • This None declaration asks for AnyCPU, but a Platform with that value is not generated in the bin folder.

The second one is our best lead here. If you declare Platform as a global property, the build succeeds:

./tooling/Build-Toolkit-Components.ps1 -MultiTargets all -Components AppServices -ExcludeMultiTargets wasdk -WinUIMajorVersion 2 -NupkgOutput ./ -Release -bl -AdditionalProperties @{ "Platform" = "x64" }

@Sergio0694 This may be related to modern .NET support now being enabled for UWP on AppServices. We shouldn't have to declare this as a global property, I think. What do you recommend?

@Sergio0694
Copy link
Member

Sergio0694 commented Jan 3, 2025

Package is building but the content is completely missing the UAP and UWP .NET 8/9 TFMs. Reopening this.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants