Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Build Jobs #365

Open
34 tasks
michael-hawker opened this issue Feb 10, 2023 · 0 comments
Open
34 tasks

Optimize Build Jobs #365

michael-hawker opened this issue Feb 10, 2023 · 0 comments
Labels
bug 🐛 Something isn't working build 🔥 CI/pipeline 🔬 dev loop ➰ For issues that impact the core dev-loop of building experiments

Comments

@michael-hawker
Copy link
Member

michael-hawker commented Feb 10, 2023

Describe the bug

Currently our WinUI2 build is taking like 90 minutes... 😟

We should split things up to ensure we can have quicker response times on feedback for the CI.

Related issues #66, #133, CommunityToolkit/Tooling-Windows-Submodule#9, (and CommunityToolkit/Tooling-Windows-Submodule#6)

We can try and mitigate this in a few ways:

  • Split up building experiments as NuGet packages from rest of build, this does a few things:
    • Means we can have them as a separate dependent job
    • Only build them once
    • Include as artifacts to the build
    • Run tests on them independently
    • In PR, If tests pass, push to a nuget feed so they can be poked while rest of CI builds still more quickly
  • Use NuGet packages vs. ProjectReferences in the CI lets us: (ties into Automate Versions of Packages #133)
  • Detect which things have changed ([Build] Experiment detection for intermediate build #66)
    • Only build the new-experiment job if the common/template folders or root config files have changed
    • Have a job which only builds the solution for the experiment(s) that have been modified
      • Only update NuGet package(s) of changed experiments
    • Have a job which builds/tests the infrastructure of labs vs. doing that along with other jobs (if any of it has been touched)
  • Smoke Tests - Check packages work on target frameworks (with NuGet packages and scoping above)
    • with new uno templates from dotnet new (Uno.UI & Uno.WinUI)
    • with new base UWP/WinAppSDK templates
    • Check binary package size changes (i.e. measure footprint)

Steps to reproduce

Run build...

Expected behavior

Faster feedback

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

@michael-hawker michael-hawker added bug 🐛 Something isn't working build 🔥 CI/pipeline 🔬 dev loop ➰ For issues that impact the core dev-loop of building experiments labels Feb 10, 2023
@michael-hawker michael-hawker added this to the Tooling MVP milestone Mar 7, 2023
@Arlodotexe Arlodotexe removed this from the Tooling MVP milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working build 🔥 CI/pipeline 🔬 dev loop ➰ For issues that impact the core dev-loop of building experiments
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants