Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For refunding with vesting, calculate how much they vested and add that to another burn #123

Open
GriffGreen opened this issue Sep 7, 2021 · 1 comment
Open

For refunding with vesting, calculate how much they vested and add that to another burn #123

GriffGreen opened this issue Sep 7, 2021 · 1 comment

Comments

@GriffGreen
Copy link

GriffGreen commented Sep 7, 2021 •
edited

  1. 馃毃 _refund() should check if the vesting's cliff date has been reached when calculating the amount to burn: because refund() can be called at any time, a user who waits until after the cliff period to be refunded may experience odd behaviour (either they receive some vested tokens or are unable to process the refund because the token manager fails to burn the expected amount of tokens)
@GriffGreen
Copy link
Author

see https://brettsun.notion.site/Augmented-Bonding-Curve-Review-6dfc203017f34b7a9eca5807fa0609cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GriffGreen