New Provider: Prometheus #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscalzi
reviewed
Nov 30, 2021
Changed to the direct parse provider per PR review comments. Removed the getType, knownTypes, and preParse methods.
dscalzi
reviewed
Nov 30, 2021
| import { Embed, EmbedField, EmbedAuthor } from '../model/DiscordApi' | ||
| import { DirectParseProvider } from './BaseProvider' | ||
|
|
||
| export class Prometheus extends DirectParseProvider { |
There was a problem hiding this comment.
need a link to the documentation here, see other providers as an example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new provider for Prometheus.
What it looks like in discord:
Prometheus does not send headers, at least not that I could find in the documentation provided in #126 that's why I decided to set a
x-skyhook-eventheader in thePrometheus.tsfile.Hope this helps!