Make Loupedeck Live re-use Razer Stream Controller image logic #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great discovery - thank you! As discussed in #3219 it would be great to work out what exactly has changed, so then we can add some logic to work around it - whether it's a firmware change or a change that only affects newer devices, etc. |
|
Thanks for submitting this pull request! However, I'm going to close it and come up with something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR:
This is a "dumbfix" for PR #3219.
It changes rendering condition to use same logic as one being used for Razer Stream Controller.
It might not cover all the cases, as it's possible that some Loupedecks Live don't have such logic and thus manual toggle might be needed.
Feel free to edit/discard.