Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasteboard Buffer Preferences File needs a redesign #3204

Closed
latenitefilms opened this issue Apr 3, 2023 · 0 comments · Fixed by #3223
Closed

Pasteboard Buffer Preferences File needs a redesign #3204

latenitefilms opened this issue Apr 3, 2023 · 0 comments · Fixed by #3223
Assignees
@latenitefilms
Labels
bug
Milestone
1.4.18

Comments

@latenitefilms
Copy link
Contributor

Reported by Dimitar Maratilov.

Currently due to the way we're using cp.prop, you need to save Buffer 1, before you can save Buffer 2, etc. This is a silly oversight. The fix is to save a "key" for each buffer - i.e. "1" instead of 1. However, we'll need to do some data migration to ensure backwards compatibility for those that have already saved things in their Pasteboard Buffer.
@latenitefilms latenitefilms added this to the 1.4.18 milestone Apr 3, 2023
@latenitefilms latenitefilms self-assigned this Apr 3, 2023
latenitefilms added a commit that referenced this issue Jun 15, 2023
@latenitefilms
Fixed preferences file for Pasteboard Buffer
2ede6b4 
- We were incorrectly using a number for the JSON ID. Converted to a string, so that you can do a proper lookup.
- Closes #3204
@latenitefilms latenitefilms mentioned this issue Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@latenitefilms latenitefilms

Labels
bug
Projects
None yet
Milestone
1.4.18
Development

Successfully merging a pull request may close this issue.

Fixed preferences file for Pasteboard Buffer CommandPost/CommandPost
1 participant
@latenitefilms