Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a confusion between 'cleanup' and 'skip_cleanup_if_failed' configuration params #67

Open
iliay-investing opened this issue May 9, 2024 · 0 comments · May be fixed by #76
Open

Fix a confusion between 'cleanup' and 'skip_cleanup_if_failed' configuration params #67

iliay-investing opened this issue May 9, 2024 · 0 comments · May be fixed by #76

Comments

@iliay-investing
Copy link

iliay-investing commented May 9, 2024

Problem

Currently we have configuration params cleanup and skip_cleanup_if_failed.
Despite their names sound similar, they are responsible for completely different things: cleanup controls the database re-creation before each test, and skip_cleanup_if_failed controls whether records, added by haveInDatabase() should be erased after the test.

Suggested fix

It would be good to distinguish these two 'cleanups' in documentation and in the names of config params in next major versions.
For example, to rename cleanup to repopulate (since we have populate responsible for initial database creation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant