Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto scroll to nearest 'viewable' patch #26

Open
tkeyes25 opened this issue Feb 20, 2019 · 9 comments
Open

Auto scroll to nearest 'viewable' patch #26

tkeyes25 opened this issue Feb 20, 2019 · 9 comments
Assignees
Labels
atom Heavily involves the Atom API feature research-required Need more information on the topic
Milestone

Comments

@tkeyes25
Copy link
Contributor

When user scrolls around, be able to load up the nearest set of patches automatically

@tkeyes25 tkeyes25 self-assigned this Feb 20, 2019
@robobenklein robobenklein added atom Heavily involves the Atom API feature research-required Need more information on the topic labels Feb 20, 2019
@robobenklein robobenklein added this to Backlog in Task Tracking via automation Feb 20, 2019
@robobenklein robobenklein added this to the Version 0 milestone Feb 20, 2019
@robobenklein
Copy link
Member

https://stackoverflow.com/questions/123999/how-to-tell-if-a-dom-element-is-visible-in-the-current-viewport

There is a non-jQuery listener version that we should explore there

@robobenklein
Copy link
Member

scroll patch into center of view works: https://github.com/utk-se/CodeRibbon/pull/25/files#diff-0c38785aa45d91cacd92d3ff95aa20afR55

does not work for even number of patches, and if using start/end/nearest instead of center it often ends up with partially visible patches

@tkeyes25
Copy link
Contributor Author

tkeyes25 commented Feb 22, 2019

Where did you leave off on this? I know scrollIntoView() was something we had explored beforehand @robobenklein

@tkeyes25
Copy link
Contributor Author

I see the commit, left a comment https://github.com/utk-se/CodeRibbon/pull/25/files#r259457220

@tkeyes25 tkeyes25 moved this from Backlog to In progress in Task Tracking Feb 22, 2019
@tkeyes25
Copy link
Contributor Author

tkeyes25 commented Feb 22, 2019

HELP: How do you get more than 6 patches? Hahah. I wanted to tackle #18 but cannot even get to the horizontal scrolling on multiple patches. I messed around in settings and ended up seeing the scroll bar, but only after setting my min to 4 THEN back to 3. Weird...

@robobenklein
Copy link
Member

Yeah that's exactly how you add more... increase then decrease the number in settings lol

@tkeyes25
Copy link
Contributor Author

Hahah alright, we can look into that as another issue

@robobenklein
Copy link
Member

#32 will make this easier

@robobenklein
Copy link
Member

Research required: https://github.com/lucafalasco/scroll-snap

@robobenklein robobenklein moved this from In progress to Needs review in Task Tracking Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atom Heavily involves the Atom API feature research-required Need more information on the topic
Projects
Task Tracking
  
Needs review
Development

No branches or pull requests

2 participants