-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on self-hosted without sudo
#82
Comments
We only support Ubuntu 20/22 for now, and it should work with self-hosted runners. What OS are you using? Maybe it wouldn't be a lot on our side to support it 😃
Totally, this is a legacy thing we plan to remove in v2. #83 |
It seems like checking the two
|
Yes, we can try. The only thing is the deb might not be suited for non-ubuntu distros. I'd like to reproduce, what os would be close to the one you're using? |
I'm using ubuntu. It's the only distro that is closest to a github runner I think. I can test your PR in my repo as well. |
You can try it out with the branch - name: Run benchmarks
uses: CodSpeedHQ/action@feat/no-sudo-pip-support
with:
token: ${{ secrets.CODSPEED_TOKEN }}
run: pytest tests/ --codspeed
no-sudo: true
no-pip-install: true Let me know if it fixes it :) |
As it turns out, I managed to make this work on self-hosted by installing the Successful run: https://github.com/web-infra-dev/oxc/actions/runs/6584112839/job/17888172716 |
As it turns out running codspeed on self-hosted require more work than I anticipated, let's close this and revisit the possibility of running codspeed on self-hosted in the future. Sorry for the time wasted on making the change. |
I'm experimenting with using
self-hosted
runner, but the machine doesn't havesudo
, so it threwhttps://github.com/web-infra-dev/oxc/actions/runs/6555787727/job/17804876099?pr=1009
action/src/prepare.ts
Lines 69 to 87 in cb13748
I can prepare the system with updated deps, but I'm not sure if pytest-codspeed is required for Rust 🤔
The text was updated successfully, but these errors were encountered: