Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molinillo shows already-resolved conflicts in the VersionConflict exception. #94

Open
j3pic opened this issue Mar 21, 2018 · 2 comments

Comments

@j3pic
Copy link

j3pic commented Mar 21, 2018

Error message:

Bundler could not find compatible versions for gem "does-not-exist":
  In Gemfile:
    dep2 was resolved to 0.0.1, which depends on
      does-not-exist (= 1.0.0)

Could not find gem 'does-not-exist (= 1.0.0)', which is required by gem 'dep2', in any of the sources.

Bundler could not find compatible versions for gem "librato-metrics":
  In Gemfile:
    librato-metrics (= 1.5.0)

    dependency was resolved to 0.0.1, which depends on
      librato-metrics

Clearly, there's no real conflict with librato-metrics. If you fix the does-not-exist dependency error, then the librato-metrics error goes away. I traced the problem to the version of Milinillo that's in the Bundler repo, but that bug probably exists here too.

This small project demonstrates the problem: https://github.com/j3pic/bundler-test

@greysteil
Copy link
Collaborator

Thanks for the work debugging this @j3pic - I imagine that was no mean feat, and having the test case is really useful.

Working with these errors is surprisingly complicated, as they're integral to the way the resolution process works (the full history of conflicts is required to determine how to rewind after a new conflict). However, in this case we can clearly do better.

Digging into this might take me a while, and I don't know when I'll have the time, but I'll try to get to it.

@j3pic
Copy link
Author

j3pic commented Mar 21, 2018

My attempted fix didn't pan out, BTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants